File uploads' filenames losing numeric values

[craven]

Hi Ben.

We've recently had issues with file uploads coming through blank or just not submitting any of the files. This turned out to be due to the filenames consisting completely out of numeric values.

Upon further inspection, I found that what seems to happen with Form Tools' file submission/upload process, is that all numeric values are stripped as are all spaces (which is to be expected).

We tested this on a live Form Tools site and database which we've upgraded to a 2.0.* version of Form Tools. We then also tested this occurence on a clean installation of the latest version of Form Tools with a clean database and clean form (plain HTML). The results are consistent were consistent with our previous findings.

I'm assuming this is by design? But if so, before we upgraded to this version, file uploads' filenames seemed to have been kept in tact if unique and only renamed when not unique.

Is there a way around this? I'm asking since we need a way of making file uploads unique, and one way would be using a "site ID" which include alphanumeric values. I was thinking along the lines of prefixing this ID with the pre-parser, but if the numbers get stripped during the processing then the IDs would become inaccurate.

Just a couple of thoughts. Thanks for your time.

[Ben]

Hi Craven,

Drat... Yes, the numeric values would get stripped out from filenames - that was daft of me. I'll fix this in 2.0.5.

The problem was that people were uploading files that had valid filenames on one filesystem, but caused the server to choke. Simple things like apostrophes or spaces in the filenames could cause problems on the server. To solve it, I added a whitelist character setting to the library.php file that strips out anything that isn't specified.

To fix it for your installation, just add the following variable to your config.php file:

PHP Code:

$g_filename_char_whitelist = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_-"; 


That will then permit numeric characters as well as the others. You can actually add any character there, in addition to the default chars.

Sorry for the confusion!

- Ben

[craven]

Thanks for the swift reply Ben! And thanks for the help. Much appreciated.