FormBuilder - new JS resource loading as style!

Thread Rating:

0 Vote(s) - 0 Average
1
2
3
4
5

Thread Modes

FormBuilder - new JS resource loading as style!

john-m-adams Offline

Junior Member

Posts: 4
Threads: 1
Joined: Mar 2015
Reputation: 0

Apr 1st, 2015, 1:15 PM

It appears form builder's function fb_generate_form($settings) does not check the resource type yet, and serves all resources as css.

See \modules\form_builder\global\code\generator.php , beginning line 256.

This bug also appears in the bug tracker:
Issue #365 » JavaScript Form Builder Resource applied as CSS Sheet, when specified as JavaScript type

For the time being, the best option is likely to upload a js file elsewhere, and hard code the script link into your template. That won't achieve what css.php does, as far as access control (It looks like it won't serve resources for a private form unless you're logged in, which is nice to know, if I find a reason for private forms).

Alternately, you can live dangerously, and do this for the current version:
Core 2.2.6
Formbuilder 1.0.7

Copy File:
\modules\form_builder\global\form_resources\css.php
to
\modules\form_builder\global\form_resources\js.php

In the new copy, js.php,
Change line 10:

PHP Code:
<?php 

header("Content-Type: text/css"); 

to:

PHP Code:
<?php 

header("Content-Type: text/javascript"); 

Make a backup copy of file:
\modules\form_builder\global\code\generator.php
Replace line 260:

PHP Code:
<?php 

$link = "<link type=\"text/css\" rel=\"stylesheet\" href=\"$g_root_url/modules/form_builder/global/form_resources/css.php?resource_id=$resource_id&nocache=$now{$query_str}\">"; 

with:

PHP Code:
<?php 

    $resource_type = $resource_info["resource_type"];

    if($resource_type == 'js') {

      $link = "<script type=\"text/javascript\" src=\"$g_root_url/modules/form_builder/global/form_resources/js.php?resource_id=$resource_id&nocache=$now{$query_str}\"></script>";

    } else {

      $link = "<link type=\"text/css\" rel=\"stylesheet\" href=\"$g_root_url/modules/form_builder/global/form_resources/css.php?resource_id=$resource_id&nocache=$now{$query_str}\">";

    }

No warranty provided that this is fit for any purpose. It will likely break if form builder is updated, and the bug is not fixed in the update. These instructions may not work for, or may break future or past versions.

Find

« Next Oldest | Next Newest »

Messages In This Thread

FormBuilder - new JS resource loading as style! - by poorya - Oct 18th, 2014, 11:14 PM

RE: FormBuilder - new JS resource loading as style! - by john-m-adams - Apr 1st, 2015, 5:15 AM

RE: FormBuilder - new JS resource loading as style! - by john-m-adams - Apr 1st, 2015, 1:15 PM

View a Printable Version

Users browsing this thread: 1 Guest(s)

FORUMS